[iOS] Fix RightToLeft flow direction for FormattedText #31498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where FormattedText alignment was not considering flow direction on iOS/macOS platforms. The fix ensures that when using RTL flow direction with FormattedText, the text alignment properly adjusts to match the layout direction.
- Adds flow direction awareness to FormattedStringExtensions.ToNSAttributedString method
- Maintains backward compatibility by keeping existing public method signatures
- Includes comprehensive test coverage with both device tests and UI tests
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Core/tests/DeviceTests/Stubs/LabelStub.cs | Adds FormattedText property to test stub for testing FormattedString scenarios |
| src/Core/tests/DeviceTests/Handlers/Label/LabelHandlerTests.iOS.cs | Adds device test to verify FormattedText alignment with different flow directions |
| src/Core/src/Platform/iOS/FlowDirectionExtensions.cs | Adds internal method to convert FlowDirection to UIUserInterfaceLayoutDirection |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31480.cs | Adds UI test to verify FormattedText flow direction behavior through screenshots |
| src/Controls/tests/TestCases.HostApp/Issues/Issue31480.cs | Adds test page with various FormattedText alignment scenarios for manual and automated testing |
| src/Controls/src/Core/Platform/iOS/Extensions/FormattedStringExtensions.cs | Core fix that makes FormattedText alignment respect flow direction by checking parent Label's FlowDirection |
jsuarezruiz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In
FormattedStringExtensions.ToNSAttributedString, the paragraph style alignment is not considering flow direction.The PR apply changes to the
ToNSAttributedStringmethod and because the changes apply to .NET 9, maintains backward compatibility by keeping existing public method signatures.Before
After
Added Device Tests and UITest to verify all alignment combinations for FormattedText with both LTR and RTL flow directions.
Issues Fixed
Fixes #31480